Open
Conversation
Signed-off-by: Michal Gorlas <michal.gorlas@9elements.com>
Signed-off-by: Michal Gorlas <michal.gorlas@9elements.com>
Signed-off-by: Michal Gorlas <michal.gorlas@9elements.com>
Signed-off-by: Michal Gorlas <michal.gorlas@9elements.com>
Signed-off-by: Michal Gorlas <michal.gorlas@9elements.com>
Signed-off-by: Michal Gorlas <michal.gorlas@9elements.com>
Signed-off-by: Michal Gorlas <michal.gorlas@9elements.com>
Signed-off-by: Michal Gorlas <michal.gorlas@9elements.com>
micgor32
requested review from
ArthurHeymans,
ChriMarMe,
PatrickRudolph,
rihter007,
trynity,
u1f35c,
walterchris,
xaionaro and
zaolin
as code owners
walterchris
requested changes
Mar 27, 2026
Collaborator
walterchris
left a comment
walterchris
left a comment
There was a problem hiding this comment.
The first comments is valid for 60% of the changes.
Signed-off-by: Michal Gorlas <michal.gorlas@9elements.com>
walterchris
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently liner check fails with:
Note: the CI does not check
cmd/, I covered the errcheck errors that can be seen by running the linter locally overcmd/, all staticcheck error are not covered yet. I think it would make sense to modify the workflow to also go overcmd/, but that's something for the future (as it requires quite a lot of fixing for the linter to be "green")