Skip to content

docs: add CONVENTIONS.md#600

Merged
AtomicFS merged 1 commit intomainfrom
docs/add-conventions
Feb 28, 2025
Merged

docs: add CONVENTIONS.md#600
AtomicFS merged 1 commit intomainfrom
docs/add-conventions

Conversation

@AtomicFS
Copy link
Copy Markdown
Collaborator

@AtomicFS AtomicFS commented Feb 27, 2025

  • CONTRIBUTING.md is more about general contributing guidelines, such as creating issues, creating pull reqeusts and so on
  • CONVENTIONS.md defines coding, formatting, and architectural standards
  • CONVENTIONS.md / Guidelines for writing good functional code originates from: https://github.com/Aider-AI/conventions

fixes #501

@AtomicFS AtomicFS marked this pull request as ready for review February 27, 2025 09:22
@AtomicFS AtomicFS requested a review from MDr164 as a code owner February 27, 2025 09:22
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 27, 2025
@AtomicFS AtomicFS enabled auto-merge February 27, 2025 09:23
@AtomicFS AtomicFS disabled auto-merge February 27, 2025 09:25
@AtomicFS AtomicFS force-pushed the docs/add-conventions branch from a17c499 to c9689f3 Compare February 27, 2025 09:49
@AtomicFS AtomicFS enabled auto-merge February 27, 2025 09:49
@AtomicFS AtomicFS force-pushed the docs/add-conventions branch from c9689f3 to a8f7f61 Compare February 27, 2025 09:54
@github-actions github-actions bot added the testing Testing related label Feb 27, 2025
@AtomicFS AtomicFS force-pushed the docs/add-conventions branch 3 times, most recently from 75902f5 to 093ce42 Compare February 27, 2025 10:07
Copy link
Copy Markdown
Collaborator

@MDr164 MDr164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good, just minor changes

- CONTRIBUTING.md is more about general contributing guidelines, such as
  creating issues, creating pull reqeusts and so on
- CONVENTIONS.md defines coding, formatting, and architectural standards
- CONVENTIONS.md / Guidelines for writing good functional code originates
  from: https://github.com/Aider-AI/conventions

Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
@AtomicFS AtomicFS added this pull request to the merge queue Feb 28, 2025
@AtomicFS AtomicFS added this to the v0.15.0 release milestone Feb 28, 2025
Merged via the queue into main with commit cf233a7 Feb 28, 2025
43 checks passed
@AtomicFS AtomicFS deleted the docs/add-conventions branch February 28, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation testing Testing related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants