Skip to content

feat: update edk2 containers#602

Merged
AtomicFS merged 4 commits intomainfrom
feat/github-ci-better-composite
Feb 28, 2025
Merged

feat: update edk2 containers#602
AtomicFS merged 4 commits intomainfrom
feat/github-ci-better-composite

Conversation

@AtomicFS
Copy link
Copy Markdown
Collaborator

  • add script to easily switch to python2
  • add note about this script into documentation
  • add NodeJS into some containers that were missing it (for more info look into the commit message)

fixes #442

- users might want to run GitHub actions in the containers, which
  requires NodeJS
- all other containers already have NodeJS in them, this patch unifies
  them

Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
- for bulding Intel FSP, often python2 is still required
- in edk2 modules people can switch to python2 by writing all the
  commands into the 'build_command' string, but it is cumbersome
- we add this single script to do all the work for the users

Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
- for some reason this edk2 entry was missing PYTHON_VERSION argument
- this is only cosmetic change, it does not change any contianer as
  Python3 is already default, it just makes it more explicit

Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation feature New feature or request docker docker related module/edk2 module/u-root labels Feb 27, 2025
- and add first entry about python versions for building Intel FSP

Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
@AtomicFS AtomicFS force-pushed the feat/github-ci-better-composite branch from eb683b8 to 23bccd9 Compare February 27, 2025 15:05
@AtomicFS AtomicFS marked this pull request as ready for review February 27, 2025 21:20
@AtomicFS AtomicFS requested a review from MDr164 as a code owner February 27, 2025 21:20
@AtomicFS AtomicFS enabled auto-merge February 27, 2025 21:20
Copy link
Copy Markdown
Collaborator

@MDr164 MDr164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lpgtmig

@AtomicFS AtomicFS added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit f11698d Feb 28, 2025
111 checks passed
@AtomicFS AtomicFS deleted the feat/github-ci-better-composite branch February 28, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docker docker related documentation Improvements or additions to documentation feature New feature or request module/edk2 module/u-root

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make it easy to switch to python2 in edk2 containers

2 participants