Merged
Conversation
- users might want to run GitHub actions in the containers, which requires NodeJS - all other containers already have NodeJS in them, this patch unifies them Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
- for bulding Intel FSP, often python2 is still required - in edk2 modules people can switch to python2 by writing all the commands into the 'build_command' string, but it is cumbersome - we add this single script to do all the work for the users Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
- for some reason this edk2 entry was missing PYTHON_VERSION argument - this is only cosmetic change, it does not change any contianer as Python3 is already default, it just makes it more explicit Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
- and add first entry about python versions for building Intel FSP Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
eb683b8 to
23bccd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python2fixes #442