Merged
Conversation
ArthurHeymans
force-pushed
the
GenericSerprog
branch
2 times, most recently
from
8c559d3 to
d5c2c1e
Compare
Contributor
Author
|
tested and works |
ArthurHeymans
force-pushed
the
GenericSerprog
branch
2 times, most recently
from
4a8ff80 to
6f57df6
Compare
This makes it easy to reuse on a different project. Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
ArthurHeymans
force-pushed
the
GenericSerprog
branch
2 times, most recently
from
17eaa17 to
48fb239
Compare
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
This makes the module more reusable for high speed and other methods like serial and tcp. Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
ArthurHeymans
force-pushed
the
GenericSerprog
branch
from
48fb239 to
875f905
Compare
MDr164
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use traits for serprog so the code is reusable and then move the serprog code to a separate workspace.
The idea is that you could have different hardware live in separate workspaces all using the same library.