Closed
Conversation
Collaborator
Which PR are we talking about? :D |
This makes it easy to reuse on a different project. Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
ArthurHeymans
force-pushed
the
UpdateEmbassyRp
branch
from
d592a21 to
8725825
Compare
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
This makes the module more reusable for high speed and other methods like serial and tcp. Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
ArthurHeymans
force-pushed
the
UpdateEmbassyRp
branch
from
8725825 to
5f76937
Compare
Contributor
Author
No idea |
The latest release should include that PR. Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
ArthurHeymans
force-pushed
the
UpdateEmbassyRp
branch
from
5f76937 to
19b419f
Compare
Collaborator
|
The pinning of the commit hashes was done in order to keep all embassy modules in sync to their current git state. All of the embassy stuff is in a big monorepo and crate version tend to get out of sync. Technically we could just rely on the crate versions for this project though, there shouldn't be too much of a difference for this chip. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should have the PR