Skip to content

Conversation

@rhaegar325
Copy link
Collaborator

Polished version:
This PR updates Mopper to be compatible with OM2 data. The main changes include: adding st_ocean as a coordinate, handling the x and y grids separately, and updating the mechanism for lon_bnds and lat_bnds.

@codecov
Copy link

codecov bot commented Sep 24, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@rhaegar325
Copy link
Collaborator Author

Hi, @dougiesquire, I hope this isn’t too much of a disturbance. This PR includes calculations and processing related to the ACCESS-OM2 grid. I would like to kindly ask you to review it and verify whether our approach is correct.

@rhaegar325
Copy link
Collaborator Author

Hi, @dougiesquire, Based on our discussion in Tuesday’s meeting, I’ve updated MOPPeR to use different classes for handling different grid types. The calculation part is implemented in src/access_mopper/ocean_supergrid.py.
Could you please have a look and check if the implementation looks correct? Thanks!

@rbeucher rbeucher changed the base branch from v2 to main October 29, 2025 04:59
@rbeucher
Copy link
Member

Thanks @rhaegar325 , That looks good on my side. @dougiesquire should be back next week.

* Fix and restucture MOM supergrid logic for OM2 and OM3

* Add support for staggered variables on B-grid

* update conditional logic

* fix format

---------

Co-authored-by: rhaegar325 <[email protected]>
@rbeucher rbeucher closed this Dec 8, 2025
@dougiesquire
Copy link
Collaborator

@rbeucher did you mean to close this before merging? You merged my PR into this branch, but you didn't merge this branch into main

@rbeucher
Copy link
Member

rbeucher commented Dec 8, 2025

Oh... I messed up

@rbeucher rbeucher reopened this Dec 8, 2025
@rbeucher rbeucher merged commit 54ec175 into main Dec 8, 2025
2 checks passed
@rbeucher
Copy link
Member

rbeucher commented Dec 8, 2025

Thanks @dougiesquire , looks very clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants