Skip to content

Conversation

@rhaegar325
Copy link
Collaborator

Summary

This PR fixes a failing integration test related to processing multiple ocean variables using ACCESS_ESM_CMORiser.

What was changed

  • Updated test_cmoriser_integration.py
  • Added mock_config_om2 fixture to conftest.py
    • Provides a standardized ACCESS-OM2 configuration for reusable test setup

Bug Fix

Previously, the integration test passed an incomplete configuration, which caused incorrect CMOR variable mapping when using compound names. With the new fixture and corrected patch logic, the expected CMOR variable (tos from Omon.tos) is now properly validated.

@rhaegar325 rhaegar325 requested a review from rbeucher December 10, 2025 05:55
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.44%. Comparing base (a4f53c8) to head (7960647).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
+ Coverage   57.06%   57.44%   +0.37%     
==========================================
  Files          18       18              
  Lines        2399     2399              
==========================================
+ Hits         1369     1378       +9     
+ Misses       1030     1021       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rbeucher rbeucher merged commit c09a05c into main Dec 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants