Cherry-pick processor layout and masktable from 25km iaf to 25km ryf #972
Conversation
* Add mask_table.1038.63x56 * Replace AUTOMASKTABLE with offline generated masktable Add layout and iolayout * Change processor layout in nuopc.runconfig and ncpus/mem in config.yaml * Add mask_table.1038.63x56 to manifests/input.yaml * Updated checksums as part of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/20048855820 * Update docs/MOM_parameter_doc.layout * Update MOM_input according to docs/MOM_parameter_doc.layout --------- Co-authored-by: access-bot <[email protected]> Co-authored-by: Andrew Kiss <[email protected]>
|
!test repro commit |
|
❌ The Bitwise Reproducibility Check Failed ❌ When comparing:
🔧 The new checksums will be committed to this PR, if they differ from what is on this branch. Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/2637f9a45cc802958dbeac941cb5c7ca09ac6455/testing/checksum Test summary: |
dougiesquire
left a comment
dougiesquire
left a comment
There was a problem hiding this comment.
Unsolicited review. Looks good, thanks @minghangli-uni
dougiesquire
left a comment
dougiesquire
left a comment
There was a problem hiding this comment.
Actually hang on one sec
|
See #1004 |
|
@dougiesquire Should I update the "corrected" numbers here or align them with the 25km iaf configuration for consistency? |
|
If you have the updated layout ready to go, maybe just close this PR and open a new one to |
|
@minghangli-uni any updates here? Would be good to get this sorted and get things consistent again across our config branches |
|
Now that 94b7eb3 has been merged, I’ll redo the processor layout - it should be much faster with this change in place. |
1. Summary:
What has changed?
config.yaml, MOM_input, nuopc.runconfig, docs/MOM_parameter_doc.layout, and manifests/input.yaml.
Why was this done?
Remain consistency with #970
2. Issues Addressed:
3. Dependencies (e.g. on payu, model or om3-scripts)
This change requires changes to (note required version where true):
4. Ad-hoc Testing
What ad-hoc testing was done? How are you convinced this change is correct (plots are good)?
5. CI Testing
!test reprohas been run6. Reproducibility
Is this reproducible with the previous commit? (If not, why not?)
!test repro commithas been run.7. Documentation
The docs folder has been updated with output from running the model?
A PR has been created for updating the documentation?
8. Formatting
Changes to MOM_input have been copied from model output in docs/MOM_parameter_docs.short?
9. Merge Strategy