Skip to content

Conversation

micaeljtoliveira
Copy link
Member

No description provided.

@micaeljtoliveira micaeljtoliveira force-pushed the pyproject_and_readme_cleanup branch 2 times, most recently from 02e0670 to f7ef683 Compare September 16, 2025 04:30
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.20%. Comparing base (4c7acfd) to head (b19835e).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/access/parsers/__init__.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #14      +/-   ##
===========================================
- Coverage   100.00%   99.20%   -0.80%     
===========================================
  Files            7        8       +1     
  Lines          236      250      +14     
===========================================
+ Hits           236      248      +12     
- Misses           0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@micaeljtoliveira
Copy link
Member Author

@edoyango Would you mind having a look at this small PR?

Copy link
Collaborator

@edoyango edoyango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the ### From source install section is necessary (e.g. could be merged with dev install instructions), but otherwise looks good!

@micaeljtoliveira micaeljtoliveira force-pushed the pyproject_and_readme_cleanup branch from f7ef683 to 2af4e4c Compare September 18, 2025 23:12
@micaeljtoliveira micaeljtoliveira force-pushed the pyproject_and_readme_cleanup branch from 2af4e4c to b19835e Compare September 18, 2025 23:30
@micaeljtoliveira
Copy link
Member Author

@edoyango Thanks for the review! Regarding the install section in the README, I'm also not sure it's necessary, but probably does not hurt to leave it.

@micaeljtoliveira micaeljtoliveira merged commit d178fb9 into main Sep 18, 2025
4 of 6 checks passed
@micaeljtoliveira micaeljtoliveira deleted the pyproject_and_readme_cleanup branch September 18, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants