-
Notifications
You must be signed in to change notification settings - Fork 0
Add Payu JSON profiling parser #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
+ Coverage 99.20% 99.27% +0.07%
==========================================
Files 8 9 +1
Lines 250 274 +24
==========================================
+ Hits 248 272 +24
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7dfb33e
to
19c4678
Compare
hi @micaeljtoliveira @manodeep, I've added a parser for the payu json log that payu spits out for each job. If multiple For context, this is for getting the total walltime of the payu run command, to get a more realistic/reliable number for scaling. The dump also includes the other steps in payu which is also included in the parsing. It discards everything else unrelated to timing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! There are a couple of copy-paste errors and some missing docstrings, but otherwise this should work.
I assume the tests passed locally?
@manodeep Thanks for reviewing. I've fixed the copy-paste errors and the fh handling and memory we can add later if needed. If there aren't any issues, can you approve this pull request? |
LGTM! Agreed - the filename/filehandle stuff we can add in later, but wanted to make sure that the docstrings clarify what is accepted as input. |
@edoyango Merging is blocked because of commits without verified signatures - can you please fix that? |
Is waiting for infrastructure in #10 to be merged
This adds parsers intended for extracting total job walltime from payu. payu emits a json file located at
archive/output000/payu_jobs/0/run/<jobid>.gadi-pbs.json
which contains job information from payu and PBS - delineated by payu tasks. This would be useful to understand payu overhead, and extracting total runtime for scaling.