-
Notifications
You must be signed in to change notification settings - Fork 0
Add conda and PyPI builds #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 9 9
Lines 278 278
=======================================
Hits 276 276
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@edoyango Here is another one for you! |
@dougiesquire Would you mind having a look? I know you're very busy, but you're our resident conda/pypi expert and I unashamedly stole your code ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @micaeljtoliveira. Let me know if you like help setting up the PyPI trusted publishing or Anaconda token
user: ${{ vars.ANACONDA_USER }} | ||
label: main | ||
token: ${{ secrets.ANACONDA_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to add these to the repo if you haven't already. Happy to help with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming the token is stored somewhere. bitwarden maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually have been generating a separate token for each project. There was a discussion in the Python Standards Group a while back about whether this is a good idea and I think we resolved to continue doing this.
There are some instructions here for how to generate one: https://github.com/ACCESS-NRI/dev-docs/wiki/Continuous-integration-and-Deployment#publishing-a-python-package-to-conda
They require that you are a member of the accessnri
Anaconda org. I can add you now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dougiesquire can you add me in too? (I reckon I asked this question before)
@dougiesquire Yes, would be great if you could provide some guidance here, as I'm completely new to publishing packages on PyPI and Anaconda. |
Do you want to learn or shall I just do it? The hardest part is finding the login details haha. Then it's just clicking a few buttons and copying a token |
I want to learn! |
I've added some details to my review comments |
@dougiesquire All set on Anaconda and PyPI. Now, is there a way to test everything is set correctly before merging this? |
You can try deploying to testPyPI, but in my experience that's not really a worthwhile exercise. I usually take the "suck it and see" approach. |
03f436f
to
74d4e2b
Compare
…onda and PyPI packages.
74d4e2b
to
2ca69a2
Compare
Add CI tests and a CD workflow to build and deploy Conda and PyPI packages. Code was mostly copied from other ACCESS projects.