fix: change Subplot to Axes

[siemdejong]

This PR proposes to change all matplotlib.axes.Subplot typehints and isinstance checks with matplotlib.axes.Axes to support newer matplotlib versions. This would enable users to e.g. distribute their packages using dabest with specific style files.

Fixes #183

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[Jacobluke-]

Hi @siemdejong , you will need to specify a more detailed version number for matplotlib for it to run.

[siemdejong]

Hey @Jacobluke-, thanks for considering this PR and reviewing. Does 3164aee satisfy your request?

[Jacobluke-]

Hi @siemdejong, our Python workflow test the package with the minimum supported version of Python (3.8). And matplotlib 3.8 only support Python >= 3.9 hence the workflow didn't run through. You can install pytest-mpl plugin and run pytest on the root directory on your local environment to see if all the tests pass.

[siemdejong]

Python 3.8 will reach end of life this October [1]. Are you planning to keep python 3.8 support after October?

[1] https://devguide.python.org/versions/

[Jacobluke-]

Thank you for your information, we will discuss about it in the team and likely to push commits to your PR to address this issue.

[JAnns98]

Everything looks in order! Happy to continue merging