Contrast bar feature and trimming plotter.py #186

Jacobluke- · 2024-09-17T08:20:42Z

No description provided.

Added functionality for all use cases (as far as I can see). Need more testing.

…trast=True

… edited the code

…nctions - get_params, and get_kwargs

…palette and get_fig_size

…ols to become initialize_fig function

…t duplicate code in plotter

…xtra mini meta and delta delta

… the contrast ticks to plot

…plotting the effect size curves

… and lims

…sthetics for cummings and gardner altman style plots

…r general aesthetic changes, and then also altered the fig size for show pairs+paired plots+float_contrast

…end plotting for swarmplots with color_col=True (not delta2/minimeta)

review-notebook-app · 2024-09-17T08:20:47Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

JAnns98

Significant changes, including trimming the plotter function and creating smaller functions in plot_tools and misc_tools to restructure the code and improve readability and future changes. Some additional edits are needed to add doc strings and comments to these added features in a subsequent patch.

Currently, the legend for swarmplot with color_col appears to be plotting the legend dots twice in the test images. I am unable to recreate this in my testing notebook, so it seems to be specific to test images - but we should keep this in mind in case it comes up.

JAnns98 · 2024-09-19T12:47:14Z

nbs/tests/mpl_image_tests/baseline_images/test_13_multi_2group_color.png

Issue with the legend plotting the dots twice. Seems to be a specific issue with the test images as I am currently unable to replicate this in testing.

…ntrast-bars # Conflicts: # dabest/misc_tools.py # dabest/plot_tools.py # dabest/plotter.py # nbs/API/misc_tools.ipynb # nbs/API/plot_tools.ipynb # nbs/API/plotter.ipynb # nbs/tests/mpl_image_tests/baseline_images/test_01_gardner_altman_unpaired_meandiff.png # nbs/tests/mpl_image_tests/baseline_images/test_02_gardner_altman_unpaired_mediandiff.png # nbs/tests/mpl_image_tests/baseline_images/test_03_gardner_altman_unpaired_hedges_g.png # nbs/tests/mpl_image_tests/baseline_images/test_05_cummings_two_group_unpaired_meandiff.png # nbs/tests/mpl_image_tests/baseline_images/test_07_cummings_multi_group_unpaired.png # nbs/tests/mpl_image_tests/baseline_images/test_09_cummings_shared_control.png # nbs/tests/mpl_image_tests/baseline_images/test_10_cummings_multi_groups.png # nbs/tests/mpl_image_tests/baseline_images/test_11_inset_plots.png # nbs/tests/mpl_image_tests/baseline_images/test_12_gardner_altman_ylabel.png # nbs/tests/mpl_image_tests/baseline_images/test_16_change_palette_b.png # nbs/tests/mpl_image_tests/baseline_images/test_17_change_palette_c.png # nbs/tests/mpl_image_tests/baseline_images/test_18_desat.png # nbs/tests/mpl_image_tests/baseline_images/test_19_dot_sizes.png # nbs/tests/mpl_image_tests/baseline_images/test_20_change_ylims.png # nbs/tests/mpl_image_tests/baseline_images/test_21_invert_ylim.png # nbs/tests/mpl_image_tests/baseline_images/test_22_ticker_gardner_altman.png # nbs/tests/mpl_image_tests/baseline_images/test_23_ticker_cumming.png # nbs/tests/mpl_image_tests/baseline_images/test_24_wide_df_nan.png # nbs/tests/mpl_image_tests/baseline_images/test_25_long_df_nan.png # nbs/tests/mpl_image_tests/baseline_images/test_27_gardner_altman_reflines_kwargs.png # nbs/tests/mpl_image_tests/baseline_images/test_28_unpaired_cumming_reflines_kwargs.png # nbs/tests/mpl_image_tests/baseline_images/test_47_cummings_unpaired_delta_delta_meandiff.png # nbs/tests/mpl_image_tests/baseline_images/test_52_delta_specified.png # nbs/tests/mpl_image_tests/baseline_images/test_56_delta_cohens_d.png # nbs/tests/mpl_image_tests/baseline_images/test_57_delta_show_delta2.png # nbs/tests/mpl_image_tests/baseline_images/test_58_delta_axes_invert_ylim.png # nbs/tests/mpl_image_tests/baseline_images/test_59_delta_axes_invert_ylim_not_showing_delta2.png # nbs/tests/mpl_image_tests/baseline_images/test_60_cummings_unpaired_mini_meta_meandiff.png # nbs/tests/mpl_image_tests/baseline_images/test_64_mini_meta_plot_change_palette_a.png # nbs/tests/mpl_image_tests/baseline_images/test_65_mini_meta_dot_sizes.png # nbs/tests/mpl_image_tests/baseline_images/test_69_mini_meta_cohens_d.png # nbs/tests/mpl_image_tests/baseline_images/test_70_mini_meta_not_show.png # nbs/tests/mpl_image_tests/baseline_images/test_71_unpaired_delta_g.png # nbs/tests/mpl_image_tests/baseline_images/test_99_style_sheets.png

Jacobluke- · 2024-09-23T06:20:41Z

Deleted mistakenly staged test file.
The latest commit also optimized the add_counts_to_ticks() function by

Moved lookup_value function definition outside the loop for better readability.
Simplified the lookup_value function by removing redundant exception handling and using a more concise structure.
Used str.split('\n')[-1] instead of rfind for better readability and potentially slightly better performance.
Removed the unnecessary ticks_loc variable and moved the set_major_locator call to the end of the function.
Used plot_kwargs.get("fontsize_rawxlabel") instead of checking if it's not None, which simplifies the code.

JAnns98 added 30 commits April 5, 2024 17:51

Added preliminary code

7651923

Fully functioning summary bars

7bda513

Added functionality for all use cases (as far as I can see). Need more testing.

Added summary bars and edited aesthetic of contrast and swarm bars

cb28e6c

Moved the summary bars, contrast bars, and swarm bars into plot_tools

d4d62cf

Fixed coloring of summary bars and added delta text (WIP)

641c4ed

Moved main delta_text code to a separate function in plot_tools

ab8aa9f

Bug fix and increased default alpha for contrast and swarm bars

b4763ca

Edits to delta-text to fit better on plots (especially when float_con…

43d61b3

…trast=True

delta text bug fixes and added delta-delta and mini-meta support

83201f9

Bug fixes and allowing contrast bars to work on float_contrast plots

74d3f3c

Bug fixes and cleaning up delta code

e196bc0

Removed old delta text code

3c54561

Moved delta dots to a separate function in plot_tools and renamed and…

2982292

… edited the code

Added more kwargs options for deltadots

601b74e

Trimmed plotter function to move some code into two new misc_tools fu…

853ff52

…nctions - get_params, and get_kwargs

Trimmed plotter by creating two new misc_tools functions - get_color_…

f1e2872

…palette and get_fig_size

Further trimming to plotter, changed get_fig_size function in misc_to…

c5f8bd2

…ols to become initialize_fig function

minor edits

b5542bc

More trimming and move code to misc_tools

a14be86

bug fix for 'gridkey' missing argument

3f65777

Created a slopegraph_plotter function in plot_tools and trimmed plotter

667909b

Further trimming and moving extra params to misc_tools to help preven…

889bede

…t duplicate code in plotter

removed redundant code

fb26eb0

Further trimming to group_summaries section of plotter

ac36489

Edit and moving some sankey code

af1efba

Created a function in plot_tools to plot the contrast curve for the e…

6f8cb0d

…xtra mini meta and delta delta

Further trimmed plotter and created function in misc_tools to extract…

21509c9

… the contrast ticks to plot

Further trimmed plotter and created a new function in plot_tools for …

4724cb4

…plotting the effect size curves

removing the commented out code from prior change

c298824

Moved gridkey to separate function in plot_tools

a9b6e52

JAnns98 added 10 commits September 10, 2024 15:21

trimmed plotter and created new function in plot_tools - barplotter

10d13d3

Trimmed plotter and added a function in misc_tools to edit the xticks…

f3338dc

… and lims

Trimmed plotter and added new functions in misc_tools to edit plot ae…

36e3533

…sthetics for cummings and gardner altman style plots

Further trimming to plotter and created new function in misc_tools fo…

d91f285

…r general aesthetic changes, and then also altered the fig size for show pairs+paired plots+float_contrast

removed unnecessary imports

d319644

formatting changes

6f59874

Trimming down plotter

ddeefa7

Preliminary changes to plotter and scatterplot functions to allow leg…

2df0aff

…end plotting for swarmplots with color_col=True (not delta2/minimeta)

Edit text for swarmplot legend

57f0c58

Minor text changes

4528455

Jacobluke- added 2 commits September 19, 2024 13:24

Fix a silly mistake in type hint

c79688d

Generate test image baseline for contrast bar

144179b

Jacobluke- requested a review from JAnns98 September 19, 2024 06:01

JAnns98 approved these changes Sep 19, 2024

View reviewed changes

Jacobluke- merged commit d5e9c58 into vnbdev Sep 23, 2024
4 checks passed

Jacobluke- deleted the feat-contrast-bars branch September 23, 2024 06:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Contrast bar feature and trimming plotter.py #186

Contrast bar feature and trimming plotter.py #186

Uh oh!

Jacobluke- commented Sep 17, 2024

Uh oh!

review-notebook-app bot commented Sep 17, 2024

Uh oh!

JAnns98 left a comment

Uh oh!

JAnns98 Sep 19, 2024

Uh oh!

Jacobluke- commented Sep 23, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Contrast bar feature and trimming plotter.py #186

Contrast bar feature and trimming plotter.py #186

Uh oh!

Conversation

Jacobluke- commented Sep 17, 2024

Uh oh!

review-notebook-app bot commented Sep 17, 2024

Uh oh!

JAnns98 left a comment

Choose a reason for hiding this comment

Uh oh!

JAnns98 Sep 19, 2024

Choose a reason for hiding this comment

Uh oh!

Jacobluke- commented Sep 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Jacobluke- commented Sep 23, 2024 •

edited

Loading