Baseline ec #191
Merged
Baseline ec #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
JAnns98
reviewed
Oct 18, 2024
There was a problem hiding this comment.
Everything looks good. Only concern/thought is that we should decide how to properly shorthand reference 'effectsize curve'. I assume thats what EC refers to in this case, but for other cases (like gridkey), its been referenced as ES (e.g., gridkey_show_es). Not sure which would be more intuitive but we should stick to one.
|
I was confused about this naming as well. I use the same as in dabestr. |
Fixed a bug where some baseline line error curve for certain controls are wrongly plotted as the previous one. The implementation is a bit different from dabestr becuase R allows nesting DataFrame where Python doesn’t.
Jacobluke-
added a commit
that referenced
this pull request
Dec 20, 2024
commit 7c2e9c9 Merge: d3d531f 1c660f8 Author: Jacob Luke <[email protected]> Date: Fri Dec 20 11:25:45 2024 +0800 Merge pull request #191 from ACCLAB/baseline_ec Baseline ec commit 1c660f8 Author: Jacobluke- <[email protected]> Date: Fri Oct 25 14:15:32 2024 +0800 pandas deprecation related to categories commit 5df90f8 Author: Jacobluke- <[email protected]> Date: Mon Oct 21 17:09:15 2024 +0800 Bug fix and zero-dot effect size for baseline Fixed a bug where some baseline line error curve for certain controls are wrongly plotted as the previous one. The implementation is a bit different from dabestr becuase R allows nesting DataFrame where Python doesn’t. commit 994003c Author: Jacobluke- <[email protected]> Date: Fri Oct 18 14:51:50 2024 +0800 Add tests for baseline curve commit 91ff9be Author: Jacobluke- <[email protected]> Date: Fri Oct 18 14:51:38 2024 +0800 Prevent deprecation warning for pandas commit 2fc8052 Author: Jacobluke- <[email protected]> Date: Fri Oct 18 14:15:02 2024 +0800 Add support for baseline_curve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.