Skip to content

Fix pooled variance calculation #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Fix pooled variance calculation #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# DABEST-Python

DABEST-Python
================

<!-- WARNING: THIS FILE WAS AUTOGENERATED! DO NOT EDIT! -->

Expand Down
5 changes: 4 additions & 1 deletion dabest/_stats_tools/confint_2group_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,10 @@ def compute_interval_limits(bias, acceleration, n_boots, ci=95):

@njit(cache=True)
def calculate_group_var(control_var, control_N, test_var, test_N):
return control_var / control_N + test_var / test_N

pooled_var = ((control_N - 1) * control_var + (test_N - 1) * test_var) / (control_N + test_N - 2)

return pooled_var


def calculate_weighted_delta(group_var, differences):
Expand Down
5 changes: 4 additions & 1 deletion nbs/API/confint_2group_diff.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,10 @@
"\n",
"@njit(cache=True)\n",
"def calculate_group_var(control_var, control_N, test_var, test_N):\n",
" return control_var / control_N + test_var / test_N\n",
" \n",
" pooled_var = ((control_N - 1) * control_var + (test_N - 1) * test_var) / (control_N + test_N - 2) \n",
" \n",
" return pooled_var\n",
"\n",
"\n",
"def calculate_weighted_delta(group_var, differences):\n",
Expand Down