Many final changes #203
Merged
Many final changes #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JAnns98
commented
Mar 26, 2025
JAnns98
commented
- Bug fixes
- Tutorials and readme updated
- Added tests
- Added additional arguments
- Major forest plot code updates and added features
- Trimmed various sections of code
> Minor edits to readme > Added short code snippet for delta-delta proportion plots to tutorial
Added permutation pvalue adjustment option in load
…essible via the gridkey_kwargs > Added fontsize and labels_fontsize functionality to gridkey > Added extra image tests for these > Updared tutorial section to include these kwargs
> fix bug where delta text doesnt display the mini-meta or delta delta delta if x_coordinates or y_coordinates are used
…tionalities
> Add error if ci_type is not given as 'bca' or 'pct'
> fix group_summaries such that none can now be provided in case you dont want to show them
> fix barplot errorbar to hide group_summaries if errorbar is selected and removed 'ci' argument from plotter as it doesnt make sense and was only used for the barplot_kwargs errorbar
>Added ability to add 'width' to barplot_kwargs so can use bar_width or the barplot_kwargs['width']
>Added ci_type argument to tutorial and also updated a warning message ('pct' instead of 'percentile')
>Fixed warning message when paired data with no color_col raises warning about legend
>Fix raw tick label fontsize if counts are not shown
>add title functionality to plots already embedded in a figure (as a subplot)
>added a raw_alpha argument to fit with the contrast_alpha argument
>change naming of parameters to be consistent. General parameters are now referred to via 'raw' or 'contrast' (e.g., raw_marker_size and contrast_marker_size)
>updated tests and tutorials to reflect the changes and updated naming
…at_contrast plots (increase width a bit)
> mini-meta delta and regular deltas from those dabest objects can be plotted alongside each other now. Added a image test for this. > updated two kwargs names for forest plot > updated forest plot tutorial
- Fixed calculation of pooled variance for control+test groups. Original calculation simply averaged variances, without consideration of sample size.
Fix pooled variance calculation
…ls code > Trimmed some plot tools functions > Adjusted delta g label name in code and tutorials > two group sankey now doesnt allow flow=False if there's only two-groups (very buggy).
… tutorials > Fixed float contrast =True, contrast axis xlim > Updated Tutorials > Updated readme
> Updated Readme > Updated Tutorials > Added more effect size options to forest plot for delta plotting
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Update summary bar name to reference band
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.