Feature: Multicontrast object and new whorlmap #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sangyu
commented
Oct 16, 2025
sangyu
commented
- created a MultiContrast Class to handle arrays of contrast objects
- whorlmap to visualize large numbers of effect sizes concisely
- forest_plot integration ensures backward compatibility
- tests
changed to IBM Plex font family
- Added group summary lines to slopegraphs - Added ability to color effect size curves and the constrast bars and delta text via using custom_palette to paired plots
Constructing MultiContrast class with a 2d array in the form of a nested list now works to produce a 2d vortexmap.
now custom_palette dictionary can accept 0 and 1 to fill barplots
Updated slopegraph visuals and additional custom_palette options updated the design of slopegraphs to remove raw bars and include a group summary (central tendency line with error bars) Added additional coloring options: - custom_palette dict for unpaired prop plots (bar plots) can now take 0 and 1 as keys to color the filled and unfilled portions of the plots - custom_palette usage with in paired plots can now color the contrast bars and effect size curves
1. multi.ipynb was re-written to enable integration with forest_plot. * MultiContrast (mc) object data loading now incorporates Jonny's thorough data validations from forest_plot() * mc object now has a method forest_plot() that plots a forest_plot from 1-D mc objects using existing forest_plot code. 2. 10-multicontrast.ipynb tutorial edited accordingly. TODO: add unit test for mc
putting multi contrast commits into rebased vnbdev branch
updated labels to remove additional capitalisations beyond the first word
Changes mini-meta weighting to use the variance of the bootstrapped resampled mean difference distribution, rather than the sample variance. See Cochrane handbook (https://www.cochrane.org/authors/handbooks-and-manuals/handbook/current/chapter-10)
There is an issue with the permutation t-test pvalue test that I'm not sure how to fix at the moment, commented out for now.
Updated baseline image for mini-meta forest plot test to presumably account for the slightly different weighted deltas. This is so pytest can stop failing on Github
Fixes mini-meta weight calculation
Minor fixes for 2d mc forest plot integration Name change to whorlmap Rearranging tutorial order
rebasing multicontrast
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
sangyu
merged commit 454c4dc
into
ACCLAB:feat-multicontrast_whorlmap_forest_plot_integration
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.