Conversation
Fixed mismatch Ns detection for paired data
Fixed mismatch Ns not working for Permutation Tests
added show_legend function for users to control whether legend should be visible.
Shifted show_legend to plot_kwargs
Updated to include show_legend parameter to control whether legend will be shown
Update 999_plot_kwargs.R
Update 001_plotter.R
Add legend removal
Added new templates for contributing to dabestr
Feat/forest plot
fix: syntax issue
fix: authors and content references for pkgdown site
update: added correct version for DABEST combined release
update: added brief release notes
maiyishan
approved these changes
May 8, 2025
Collaborator
maiyishan
left a comment
There was a problem hiding this comment.
Code looks good, I'll go ahead and merge this now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes