Modify dabestr print to make greeting/ending optional and fix formatting#185
Open
marsiwiec wants to merge 9 commits intoACCLAB:devfrom
Open
Modify dabestr print to make greeting/ending optional and fix formatting#185marsiwiec wants to merge 9 commits intoACCLAB:devfrom
marsiwiec wants to merge 9 commits intoACCLAB:devfrom
Conversation
Merge dev branch into master branch
Update contributors list
v2023.9.12 along with favicon updates
Added swarm bars, forest plot function
- add 'print_greet_end' argument to print methods - fix unnecessary 'character 0' instead of empty string in print. - fix typos related to double-escaped newlines - rearrange wording for the reporting of confidence intervals in print methods
ggplot2 transitioned from S3 class to S7 class, hence affecting several functions including ``` expect_s3_class(p, "ggplot") expect_length(p, 11) expect_type(p, "list") ``` which directly affects the testing script for function add_scaling_component_to_delta_plot(). The output of this function is a list, and the first element of the list is a ggplot2 object.
marsiwiec
force-pushed
the
master
branch
3 times, most recently
from
2f8eb5c to
00532d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is a relatively straightforward change to make the additional text in printed summaries ("greeting" and "ending") optional via a print_greet_end boolean argument to print methods (defaulting to TRUE, thus not changing default behavior). This makes it easier to directly paste into reports etc.
Also included are some formatting fixes and improved formatting for confidence intervals, which facilitates automated reporting.