Closed
Conversation
Instead of assuming /24 for all discovered devices, now parses the CIDR prefix from the scanner's configured address (e.g., "192.168.1.12/22:47808") and uses that prefix length for devices on the local network. Falls back to /24 only when no local subnet info is available. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Enhances local subnet detection by querying the operating system's network interfaces (via ifconfig/ip addr) to find the actual netmask for the scanner's IP address. This ensures accurate subnet detection even when the configured address uses a different CIDR notation. - Adds _get_system_interfaces() to parse ifconfig (macOS) and ip addr (Linux) - Adds _detect_local_subnet() to match scanner IP to system interfaces - Removes conflicting subnets from config when detected subnet differs - Falls back to address config CIDR if interface detection fails Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…o merge-cristian-and-jackson-fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes duplicate vendor ID issues on startup
Merges routers and router devices
Adds scavenge scan
Update config for scavenge