Merged
Conversation
thomash-acinq
force-pushed
the
refactor-router
branch
from
9147c41 to
b51a27e
Compare
thomash-acinq
force-pushed
the
refactor-router
branch
from
b51a27e to
4716a5f
Compare
t-bast
reviewed
Jan 8, 2025
Member
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
Nice refactoring! It will make it easier to introduce new WeightRatios by simply extending the trait and implementing addEdgeWeight, I like it 👍
eclair-core/src/main/scala/fr/acinq/eclair/remote/EclairInternalsSerializer.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/router/RouteCalculation.scala
Outdated
Show resolved
Hide resolved
...src/test/scala/fr/acinq/eclair/integration/basic/zeroconf/ZeroConfAliasIntegrationSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/payment/MultiPartPaymentLifecycleSpec.scala
Outdated
Show resolved
Hide resolved
thomash-acinq
changed the title
t-bast
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the route finding to share the same code for payment routes and onion message routes.