Conversation
sstone
force-pushed
the
maven-checksums
branch
from
8ba1725 to
e4ff206
Compare
Maven build process will compute checksums for our dependencies and verify them against a local "trusted checksums" file, and fail the build if the do not match. This process is local and independent of checksums stored and downloaded from maven repositories. SNAPSHOT dependencies are not verified (but released versions should never depend on SNAPSHOT dependencies).
sstone
force-pushed
the
maven-checksums
branch
from
e4ff206 to
d2f54af
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2986 +/- ##
==========================================
- Coverage 86.02% 86.00% -0.03%
==========================================
Files 227 227
Lines 20340 20368 +28
Branches 834 850 +16
==========================================
+ Hits 17498 17517 +19
- Misses 2842 2851 +9 |
t-bast
requested changes
Jan 24, 2025
The correct version of the JDK is enough, Eclair uses the maven wrapper now which will download the version of maven that it needs on first use.
sstone
force-pushed
the
maven-checksums
branch
from
19960df to
ca277a6
Compare
t-bast
reviewed
Jan 27, 2025
t-bast
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use a feature added to maven 3.9.x to compute checksums for our dependencies and verify them against a local "trusted checksums" file, and fail the build if the do not match. This process is local and independent of checksums stored and downloaded from maven repositories.
SNAPSHOT dependencies are not verified (but released versions should never depend on SNAPSHOT dependencies).
This should protect us against supply-chain attacks where some of our dependencies are compromised and replaced by malicious ones.