Clarify recipient blinded path fee deduction#3010
Merged
thomash-acinq merged 1 commit intofee-less-blinded-routefrom Feb 24, 2025
Merged
Clarify recipient blinded path fee deduction#3010thomash-acinq merged 1 commit intofee-less-blinded-routefrom
thomash-acinq merged 1 commit intofee-less-blinded-routefrom
Conversation
We clarify that the previously named "hiddenFee" is actually the blinded path fee that is being paid by the recipient (by deducing it from the amount it plans on receiving). We thus rename variables and add docs. We also revert the validation flow: instead of generating a payment part for that fee based on the difference between the paid amount and the onion value, we generate that payment part based on the blinded path fee we recorded in the `path_id` and validate that it matches what the payer is sending. We revert some of the changes to the `MultiPartHandler` which aren't necessary and do some clean-up of some unused code paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We clarify that the previously named "hiddenFee" is actually the blinded path fee that is being paid by the recipient (by deducing it from the amount it plans on receiving). We thus rename variables and add docs.
We also revert the validation flow: instead of generating a payment part for that fee based on the difference between the paid amount and the onion value, we generate that payment part based on the blinded path fee we recorded in the
path_idand validate that it matches what the payer is sending.We revert some of the changes to the
MultiPartHandlerwhich aren't necessary and do some clean-up of some unused code paths.This is a PR targeting #2993: I verified that this code compiles, but didn't update the tests.