Conversation
The `listoffers` RPC previously exposed raw TLV data and omitted the `createdAt` and `disabledAt` information, which made it quite useless. We now return all of the useful offer data, which makes it easier for node operators to manage their offers.
If we register the same offer twice, this will crash because we're not handling primary key constraints failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two separate commits that should have been done as part of #2976 but unfortunately were missed because of insufficient testing...
The
listoffersRPC previously exposed raw TLV data and omitted thecreatedAtanddisabledAtinformation, which made it quite useless. We now return all of the useful offer data, which makes it easier for node operators to manage their offers. This is added in the first commit.If we previously registered the same offer twice, this would crash because we weren't properly handling primary key constraints failures. This is fixed in the second commit.