Merged
Conversation
Since we don't have access to channel params in the `Peer` actor, we don't know the remote `htlc_minimum` when receiving a splice. This may lead to cases where we later fail because we end up with a negative funding fee, which doesn't make any sense. To avoid those failures, we hard-code the `htlc_minimum` value used by Phoenix (which is the only consumer of this protocol so far) and use the max with our local `htlc_minimum`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we don't have access to channel params in the
Peeractor, we don't know the remotehtlc_minimumwhen receiving a splice. This may lead to cases where we later fail because we end up with a negative funding fee, which doesn't make any sense.To avoid those failures, we hard-code the
htlc_minimumvalue used by Phoenix (which is the only consumer of this protocol so far) and use the max with our localhtlc_minimum.