Stop storing channel errors in AuditDb
#3236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We stop storing every `ChannelErrorOccured` event in the `AuditDb`. This is very spammy because there are a lot of non-fatal events, and they turned out to be unnecessary for auditing (they make more sense in the logs for debugging). Such events include for example notifying that we tried to relay a payment to a channel that didn't have enough balance, or commands sent to channels that are offline, closing or reconnecting. Note that we stop creating the corresponding table, but we don't delete old data: it is up to node operators to decide whether they want to keep it or not. We still support migrating older databases including data from this table. We also remove tests from very old migrations (more than 2 years old) which are spammy but not very interesting anymore.
pm47
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We stop storing every
ChannelErrorOccuredevent in theAuditDb. This is very spammy because there are a lot of non-fatal events, and they turned out to be unnecessary for auditing (they make more sense in the logs for debugging).Such events include for example notifying that we tried to relay a payment to a channel that didn't have enough balance, or commands sent to channels that are offline, closing or reconnecting.
Note that we stop creating the corresponding table, but we don't delete old data: it is up to node operators to decide whether they want to keep it or not. We still support migrating older databases including data from this table.
We also remove tests from very old migrations (more than 2 years old) which are spammy but not very interesting anymore.