Rework channel lifecyle events #3237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We emit several events during the channel lifecycle, which have become a bit of a mess over the years, especially with the addition of 0-conf, splicing and on-the-fly funding. We now use the following events: - `ChannelCreated` once the funding transaction is created - `ChannelFundingConfirmed` once the funding transaction is confirmed, which is also emitted for splice transactions - `ChannelReadyForPayments` once the channel is ready for payments, after exchanging `channel_ready` for the channel creation or `splice_locked` for splice transactions The order between `ChannelFundingConfirmed` and `ChannelReadyForPayments` depends on whether 0-conf is used or not. We remove `ChannelOpened`, which was actually a subset of the existing `ChannelReadyForPayments` event (which was added afterwards). We add a few fields to existing channel events, which we don't yet store in the DB to avoid modifying it, but will store later when we modify the schema of the `AuditDb`. We now store an entry in the `AuditDb` whenever a splice transaction confirms, which allows tracking the full history of a channel's changes.
pm47
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We emit several events during the channel lifecycle, which have become a bit of a mess over the years, especially with the addition of 0-conf, splicing and on-the-fly funding.
We now use the following events:
ChannelCreatedonce the funding transaction is createdChannelFundingConfirmedonce the funding transaction is confirmed, which is also emitted for splice transactionsChannelReadyForPaymentsonce the channel is ready for payments, after exchangingchannel_readyfor the channel creation orsplice_lockedfor splice transactionsThe order between
ChannelFundingConfirmedandChannelReadyForPaymentsdepends on whether 0-conf is used or not.We remove
ChannelOpened, which was actually a subset of the existingChannelReadyForPaymentsevent (which was added afterwards).We add a few fields to existing channel events, which we don't yet store in the DB to avoid modifying it, but will store later when we modify the schema of the
AuditDb.We now store an entry in the
AuditDbwhenever a splice transaction confirms, which allows tracking the full history of a channel's changes.