Add secondary pseudo-random number generator #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
secondary-rng
branch
2 times, most recently
from
776180a to
b469710
Compare
robbiehanson
previously approved these changes
Apr 22, 2021
robbiehanson
previously approved these changes
Apr 22, 2021
We want to ensure the application doesn't access it directly and instead uses our utility functions that will mix in additional randomness.
In case of catastrophic failures of the SecureRandom instance, we add a secondary randomness source that we mix into the random stream. This is a somewhat weak random source and should not be used on its own, but it doesn't hurt to xor it with the output of SecureRandom. The `runtimeEntropy` should be customized for iOS and Android.
Collect some runtime statistics for iOS.
Collect some JVM statistics.
t-bast
force-pushed
the
secondary-rng
branch
from
d4a15f2 to
6db1ded
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of catastrophic failures of the OS
SecureRandominstance, we add a secondary randomness source that we mix into the random stream.This is a somewhat weak random source and should not be used on its own, but it doesn't hurt to xor it with the output of
SecureRandom.The
runtimeEntropyshould be customized for iOS and Android by fetching all kind of random noise available to the application (available memory, process ID, sensor data, network statistics, etc).Thanks @robbiehanson for the iOS code!