Skip to content

fix(id): shorten FAQ button label and use string resource for inbound liquidity#801

Open
Rovikin wants to merge 11 commits intoACINQ:masterfrom
Rovikin:translate-id
Open

fix(id): shorten FAQ button label and use string resource for inbound liquidity#801
Rovikin wants to merge 11 commits intoACINQ:masterfrom
Rovikin:translate-id

Conversation

@Rovikin
Copy link
Copy Markdown
Contributor

@Rovikin Rovikin commented Mar 23, 2026

  • Shorten FAQ button label from 'Pertanyaan yang Sering Diajukan (FAQ)' to 'FAQ' to fit UI constraints
  • Replace hardcoded 'Inbound liquidity' string in WalletView.kt with string resource channelsview_inbound

@Rovikin
Copy link
Copy Markdown
Contributor Author

Rovikin commented Mar 23, 2026

Changes explanation:

  1. FAQ button label — shortened from 'Pertanyaan yang Sering Diajukan (FAQ)' to 'FAQ' because the original translation was too long and got truncated in the UI (visible as 'Pertanyaan y...' on the button).

  2. WalletView.kt — replaced hardcoded 'Inbound liquidity' string with stringResource(R.string.channelsview_inbound) which already exists in strings.xml. This also fixes the string not being translated in the Indonesian locale.

Copy link
Copy Markdown
Member

@dpad85 dpad85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix.

A few changes are needed:

  • the values-id folder and its content need to be removed. Although id is the ISO code for Indonesia, Android uses in for the resource files instead (see commit 3f3db8b)
  • the R.string.channelsview_inbound entry for Indonesian needs to be added to values-in/strings.xml
  • the R.string.channelsview_inbound entry for English must be added to values/strings.xml (that's mandatory, it will be the default value for other languages)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants