feat(profile): secure and enhance address management endpoints#206
Open
feat(profile): secure and enhance address management endpoints#206
Conversation
…ved code readability
…ved code readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces several improvements to the customer profile and address management functionality.
JWT-based Client ID Retrieval:
GET,POST, andPUTendpoints for addresses (/api/profile/addresses) now retrieve the client ID from the JWT token instead of a path variable. This enhances security by ensuring that users can only access and modify their own addresses.CustomerProfileServiceto avoid code duplication.Role-Based Access Control:
ROLE_KYC_MANAGERauthority. This is enforced using the@PreAuthorizeannotation.Improved Update Logic:
updateClientAddressmethod inFineractAddressServicehas been updated to support partial updates for all address fields, not juststreetandaddressType.Code Refactoring:
FineractAddressServicewith constants to improve code quality and maintainability.Documentation:
customer_flow.mddocumentation has been extensively updated to reflect all of the above changes.addressType,stateProvince, andcountry, and clarifies how these are mapped to IDs in Fineract.