Skip to content

Week8 backend#58

Merged
DuGuYifei merged 15 commits intomainfrom
week8-backend
Jul 19, 2025
Merged

Week8 backend#58
DuGuYifei merged 15 commits intomainfrom
week8-backend

Conversation

@DuGuYifei
Copy link
Collaborator

Closes #17
Closes #18
Closes #19
Closes #57

This pull request introduces significant updates to workflows, documentation, and configuration files to enhance CI/CD pipelines, improve documentation, and support environment-specific configurations. The most important changes are grouped below:

Workflow Enhancements

  • Added a unit-test job to the deploy-aws.yml workflow to ensure tests are run before building and deploying. This includes setting up Gradle, Java, and running tests with ./gradlew test.
  • Introduced a build-and-push job in deploy-aws.yml to build and push Docker images using docker-compose.prod.yml, with dependencies on the unit-test job.
  • Updated the docker-publish.yml workflow to dynamically set the VITE_API_BASE_URL based on the branch being deployed.

Documentation Improvements

  • Expanded the README.md with a Table of Contents, detailed "Getting Started" instructions for environment setup, Docker Compose usage, and automation scripts for Terraform, Ansible, and Kubernetes. [1] [2]
  • Added an offline API reference in api-openapi-firefox-online.md, including links to interactive API documentation and detailed endpoints for authentication, job management, and applications.

Configuration Updates

  • Added support for passing VITE_API_BASE_URL as a build argument in docker-compose.yml and docker-compose.prod.yml for environment-specific frontend configurations. [1] [2]
  • Introduced a new VITE_API_BASE_URL variable in example.env for frontend API base URL configuration.

Database Schema Adjustments

  • Updated the README_Design.md to replace custom embedding table definitions with the recommended langchain pgvector schema, improving compatibility with official tools.

Minor Fixes

  • Updated references in api-openapi-generated-stable.yaml to point to api-openapi-original-design.yaml for better alignment with the original schema design. [1] [2]

@DuGuYifei DuGuYifei requested a review from Copilot July 19, 2025 16:19
@DuGuYifei DuGuYifei self-assigned this Jul 19, 2025
@DuGuYifei DuGuYifei added area:frontend Frontend related tasks area:devops CI/CD, infrastructure tasks area:docs Documentation tasks labels Jul 19, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces significant frontend improvements and backend API adjustments to support a comprehensive HR application management system. The primary purpose is to unify field naming conventions across the codebase and implement a complete dashboard interface for HR personnel to manage job applications and conduct AI interviews.

Key changes include:

  • Field name standardization: Changed userID to userId and jobID to jobId across DTOs and services for consistent camelCase naming convention
  • Enhanced CORS support: Added PATCH method to allowed CORS methods for all services to support frontend update operations
  • Complete frontend implementation: Built comprehensive React components for HR dashboard, job management, application tracking, and AI interview functionality

Reviewed Changes

Copilot reviewed 73 out of 86 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
Backend services Updated field naming from userID/jobID to userId/jobId in DTOs and service methods
Application configurations Added PATCH to CORS allowed methods and updated password validation requirements
Chat service Enhanced AI message handling with conditional database saving and improved streaming logic
Frontend components Implemented complete dashboard interface with modals, job management, and AI chat functionality
Utils and hooks Created API configuration, authentication utilities, and custom hooks for data management
Comments suppressed due to low confidence (2)

service-application/src/main/java/de/tum/devops/application/service/ChatService.java:252

  • [nitpick] The parameter name 'isSaveToDB' uses unclear abbreviation. Consider renaming to 'shouldSaveToDatabase' or 'persistToDatabase' for better readability.
    public ChatMessage saveFinalAiMessage(UUID sessionId, String content, boolean isSaveToDB) {

@DuGuYifei DuGuYifei merged commit dc7e343 into main Jul 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:devops CI/CD, infrastructure tasks area:docs Documentation tasks area:frontend Frontend related tasks

Projects

None yet

3 participants