Conversation
| type: Opaque | ||
| data: | ||
| OLLAMA_EMBED_KEY: {{ .Values.ollama.llmKey | b64enc }} | ||
| OLLAMA_LLM_KEY: {{ .Values.ollama.llmKey | b64enc }} No newline at end of file |
There was a problem hiding this comment.
This whole secret was "hardcoded" in k8s, so now it is created with the env var directly from the github action
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring Ollama LLM keys in the Kubernetes deployment by setting up a secret template and passing the key through the GitHub Actions workflow. The changes enable the application to securely access Ollama services with proper authentication.
- Creates a new Kubernetes secret template for storing Ollama API keys
- Updates the GitHub Actions workflow to pass the Ollama LLM key from repository secrets
- Adds documentation about required secrets for deployment in other environments
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| helm/closed-ai/templates/genai-ai-secret.yaml | New secret template for storing Ollama embed and LLM keys |
| .github/workflows/deploy-k8s.yml | Added Ollama LLM key configuration to Helm deployment command |
| README.md | Updated deployment documentation with secret requirements |
Comments suppressed due to low confidence (1)
helm/closed-ai/templates/genai-ai-secret.yaml:8
- Both OLLAMA_EMBED_KEY and OLLAMA_LLM_KEY use the same source value (.Values.ollama.llmKey). If these are meant to be different keys, consider using separate values like .Values.ollama.embedKey and .Values.ollama.llmKey.
OLLAMA_EMBED_KEY: {{ .Values.ollama.llmKey | b64enc }}
| DB_PASSWORD: ${{ secrets.DB_PASSWORD }} | ||
| DB_NAME: ${{ secrets.DB_NAME }} | ||
| DISCORD_WEBHOOK_K8S: ${{ secrets.DISCORD_WEBHOOK_K8S }} | ||
| OLLAMA_LLM_KEY: ${{ secrets.OLLAMA_LLM_KEY }} |
There was a problem hiding this comment.
The indentation is inconsistent with other environment variables. This line should be indented with spaces to align with the other env variables above.
There was a problem hiding this comment.
Where exactly is the indentation inconsistent?
2 participants
No description provided.