-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/matching-service WiP #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marks all fields that aren't explicitly optional as required.
Note: Algorithm is unimplemented for now.
Add 409 return value to register match request
Tests currently fail. Will be fixed in next commit
Moving getMatchStatus(UUID groupID) into GroupService allows removing the dependency on MatchService.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Changes
Checklist
Related Issues
Merges #61 into main
Fixes #
Related to #
Additional Notes
This initial implementation of the Matching-microservice contains most of the basic logic, albeit still untested pending Gateway-service's completion.
Much of the code here comes from the automatic generation of client templates through
openapi-generator-cli. All code in*/generated-client/*is auto-generated and can safely be ignored.This is a WiP, and not all features are working.
Complete
Services
Algorithm
Controler
Skeleton / Untested
Services
Client
No Implementation
Services
Client
Algorithm