Skip to content

Feature/add cicd to build and push docker images via GitHub actions#45

Merged
GravityDarkLab merged 28 commits intomainfrom
feature/add-cicd-to-build-and-push-docker-images-via-github-actions
Jun 15, 2025
Merged

Feature/add cicd to build and push docker images via GitHub actions#45
GravityDarkLab merged 28 commits intomainfrom
feature/add-cicd-to-build-and-push-docker-images-via-github-actions

Conversation

@GravityDarkLab
Copy link
Collaborator

No description provided.

@GravityDarkLab GravityDarkLab linked an issue Jun 12, 2025 that may be closed by this pull request
8 tasks
@GravityDarkLab GravityDarkLab requested a review from Copilot June 12, 2025 10:46

This comment was marked as outdated.

- Added "test" script to package.json for running tests with Vitest and generating coverage reports.
- Included Vitest and coverage-v8 as dependencies in package.json.
- Created tsconfig.app.tsbuildinfo to manage TypeScript build information.
@GravityDarkLab GravityDarkLab requested a review from Copilot June 12, 2025 12:11

This comment was marked as outdated.

@GravityDarkLab GravityDarkLab requested a review from Copilot June 15, 2025 10:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds CI/CD workflows for building and pushing Docker images via GitHub Actions while introducing several enhancements and refactorings across the GenAI service and related modules.

  • Introduces new error schema models and logging improvements.
  • Switches several services to asynchronous operations and improves exception handling.
  • Implements multi-stage Docker builds and updates environment variable naming conventions.

Reviewed Changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
genai/src/utils/error_schema.py Adds a Pydantic-based error schema model.
genai/src/services/llm/llm_service.py Refactors LLM factory to support multiple providers with updated logging.
genai/src/services/embedding/* Enhances logging and error handling for embedding and Weaviate schema.
genai/src/services/crawler/crawler_service.py Transitions crawling functions to async with improved cache and error logic.
genai/src/main.py Updates app configuration, exception handlers, and startup sequence.
Dockerfile Implements a multi-stage build process for optimized image size.
.env and docker-compose.yml Adjusts environment variables and their naming for consistency.
GitHub Workflow files Introduces CI/CD pipelines for building, testing, and deploying multiple services.
Comments suppressed due to low confidence (2)

docker-compose.yml:41

  • Ensure that the environment variable 'SPRING_PROFILE_ACTIVES' is intentional and consistent with downstream configurations, as it deviates from the more common 'SPRING_PROFILES_ACTIVE' naming convention.
SPRING_PROFILE_ACTIVES: ${SPRING_PROFILE_ACTIVES}

.env.example:54

  • Consider renaming the environment variables from 'GEMAI_APP_NAME' and 'GEMAI_PORT' to 'GENAI_APP_NAME' and 'GENAI_PORT' for consistency with the rest of the repository.
GEMAI_APP_NAME=skill-forge-genai-test

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@GravityDarkLab GravityDarkLab merged commit 6ad0d09 into main Jun 15, 2025
9 checks passed
@GravityDarkLab GravityDarkLab deleted the feature/add-cicd-to-build-and-push-docker-images-via-github-actions branch June 18, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment