Feature/add cicd to build and push docker images via GitHub actions#45
Merged
GravityDarkLab merged 28 commits intomainfrom Jun 15, 2025
Conversation
8 tasks
…ml for testing configuration
- Added "test" script to package.json for running tests with Vitest and generating coverage reports. - Included Vitest and coverage-v8 as dependencies in package.json. - Created tsconfig.app.tsbuildinfo to manage TypeScript build information.
This was
linked to
issues
Jun 12, 2025
…ages-via-github-actions
…awler and embedding logic
…ciency and organization
…d environment variables
…hema_exists function
…s to genai service
…the GenAI service
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds CI/CD workflows for building and pushing Docker images via GitHub Actions while introducing several enhancements and refactorings across the GenAI service and related modules.
- Introduces new error schema models and logging improvements.
- Switches several services to asynchronous operations and improves exception handling.
- Implements multi-stage Docker builds and updates environment variable naming conventions.
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| genai/src/utils/error_schema.py | Adds a Pydantic-based error schema model. |
| genai/src/services/llm/llm_service.py | Refactors LLM factory to support multiple providers with updated logging. |
| genai/src/services/embedding/* | Enhances logging and error handling for embedding and Weaviate schema. |
| genai/src/services/crawler/crawler_service.py | Transitions crawling functions to async with improved cache and error logic. |
| genai/src/main.py | Updates app configuration, exception handlers, and startup sequence. |
| Dockerfile | Implements a multi-stage build process for optimized image size. |
| .env and docker-compose.yml | Adjusts environment variables and their naming for consistency. |
| GitHub Workflow files | Introduces CI/CD pipelines for building, testing, and deploying multiple services. |
Comments suppressed due to low confidence (2)
docker-compose.yml:41
- Ensure that the environment variable 'SPRING_PROFILE_ACTIVES' is intentional and consistent with downstream configurations, as it deviates from the more common 'SPRING_PROFILES_ACTIVE' naming convention.
SPRING_PROFILE_ACTIVES: ${SPRING_PROFILE_ACTIVES}
.env.example:54
- Consider renaming the environment variables from 'GEMAI_APP_NAME' and 'GEMAI_PORT' to 'GENAI_APP_NAME' and 'GENAI_PORT' for consistency with the rest of the repository.
GEMAI_APP_NAME=skill-forge-genai-test
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.