Skip to content

Add client initial setup#7

Merged
ArmanpreetGhotra merged 9 commits intomainfrom
3-setup-client-repo
May 12, 2025
Merged

Add client initial setup#7
ArmanpreetGhotra merged 9 commits intomainfrom
3-setup-client-repo

Conversation

@ArmanpreetGhotra
Copy link
Collaborator

No description provided.

@ArmanpreetGhotra ArmanpreetGhotra self-assigned this May 9, 2025
@ArmanpreetGhotra ArmanpreetGhotra requested review from leon-liang and xhulia028 and removed request for leon-liang and xhulia028 May 9, 2025 18:40
Copy link
Collaborator

@leon-liang leon-liang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put the Next.js project directly inside the client folder without the additional teamserverdown folder?

@ArmanpreetGhotra
Copy link
Collaborator Author

Can we put the Next.js project directly inside the client folder without the additional teamserverdown folder?

I think it's cleaner in my opinion if we have folder teamserverdown folder

Copy link
Collaborator

@xhulia028 xhulia028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the .gitkeep file? We don't need it, since the directory is not empty anymore.

Copy link
Collaborator

@xhulia028 xhulia028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you delete teamserverdown folder, so we can have everything in Client? teamserverdown refers to the whole project not just the client, so it is a bit confusing to have such a folder in client. Also Dockerfile is usually on the same level as package.json.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity where did you get the styles from?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's get created when you install tailwind/css

@ArmanpreetGhotra ArmanpreetGhotra marked this pull request as ready for review May 11, 2025 08:11
@ArmanpreetGhotra ArmanpreetGhotra merged commit e958f9c into main May 12, 2025
3 checks passed
@leon-liang leon-liang deleted the 3-setup-client-repo branch June 14, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants