Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
- Fix the current ESLint issues
- Consider adding Lingui ESLint plugin: https://lingui.dev/ref/eslint-plugin
- Add new NPM scripts documentations to both README and Copilot instructions
I didn't test the code yet.
About the translations and auto generated files, I think we should bring a pre-commit library like Husky to run the translation update before committing (in another PR).
There was a problem hiding this comment.
Not a problem here but argggg forced to use babel here.
If the React parser was SWC it could have use the SWC plugin instead (much faster).
Here most of the React work is made by OXC which is faster than SWC, but still rely on Babel for the React compiler, and now the Lingui plugin 😢
I want more Rust in the web 🦀
There was a problem hiding this comment.
src/components/VideoPlayer.tsx
Outdated
| </div> | ||
| <p>Drop video file here</p> | ||
| <p> | ||
| <Trans>Drop video file here</Trans> |
There was a problem hiding this comment.
Is there a reason to use <Trans> instead of t here?
We do not plan on adding nested JSX components under it at the moment.
There was a problem hiding this comment.
See https://lingui.dev/tutorials/react#macros-vs-components for the difference. At compilation the macros are transformed into <Trans>. I'll use a macro there to be more consistant
There was a problem hiding this comment.
It's not the goal of the PR here but in the short term we should have a configuration page with app language and not solely rely on the browser language.
I think we should either bring a component library or build our own but it require some brainstorming first.
In general I think we should aim at a very minimalistic UI and a settings page will quickly become a requirement (don't want a big dropdown in the control bar).
|
Conflicts 😬 There is one new string in ControlBar.tsx, fix the conflict in package.json then delete and pnpm install to recreate pnpm-lock.yaml. Should be pretty easy to fix the tsconfig. |
cbf1a61 to
ad254cf
Compare
ad254cf to
d05e513
Compare
39ad4ba to
ed9c856
Compare
First implementation of the translation mechanism.
How translate things in the code
pnpm run extractmessages.tsfiles in src/locales/*/runEDIT: done by the Vite pluginpnpm run compileI think there's room for improvements (maybe make the list of supported languages dynamic based on the existant files in locales/*...)