Disable cosign on PRs in Docker image workflow#34
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: AFCMS <61794590+AFCMS@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Disable cosign in Docker image workflow for PRs
Disable cosign on PRs in Docker image workflow
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Docker image workflow was failing on pull requests because cosign was attempting to sign images that were never pushed to the registry. While the Docker registry push and attestation steps were already conditional (
if: github.event_name != 'pull_request'), the cosign steps were running unconditionally, causing failures due to invalid tags being passed.Solution
Added the
if: github.event_name != 'pull_request'condition to all three cosign-related steps:This ensures cosign is entirely disabled on pull requests, consistent with the existing behavior for Docker registry operations.
Workflow Behavior
The Docker job now has consistent conditional logic:
On PRs, the workflow will build the Docker image for validation but skip all registry interactions and signing operations.
Fixes the issue where cosign was failing on PRs with invalid tag references.
Original prompt
Fixes #33
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.