Corpus refactoring #3159
Draft
Corpus refactoring #3159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokatoka
reviewed
Apr 14, 2025
| @@ -236,9 +236,10 @@ ahash = { workspace = true } # The hash function already used in hashbrown | |||
| meminterval = { workspace = true, features = ["serde"] } | |||
| backtrace = { workspace = true, optional = true } # Used to get the stacktrace in StacktraceObserver | |||
| typed-builder = { workspace = true, optional = true } # Implement the builder pattern at compiletime | |||
| fs4 = "0.13.1" | |||
There was a problem hiding this comment.
there should be another dependency on fs2 inside this file
can you delete that?
domenukk
reviewed
Apr 15, 2025
| @@ -227,7 +227,7 @@ hashbrown = { workspace = true, features = [ | |||
| "ahash", | |||
| ], default-features = false } # A faster hashmap, nostd compatible | |||
| num-traits = { workspace = true, default-features = false } | |||
| serde = { workspace = true, features = ["alloc"] } # serialization lib | |||
| serde = { workspace = true, features = ["alloc", "rc"] } # serialization lib | |||
There was a problem hiding this comment.
|
One big thing we may need to address for corpus at some point is that we now keep all metadata in memory at all times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.