Add libvharness and InputSetter. Set coverage map from inside the VM. Refactor commands. #3366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create a rust sys crate for libvharness. remove old (now useless) bindings.
domenukk
reviewed
Aug 19, 2025
| @@ -41,7 +41,7 @@ fn main() -> Result<(), Box<dyn Error>> { | |||
| --exclude-features=prelude,python,sancov_pcguard_edges,arm,aarch64,i386,be,systemmode,whole_archive \ | |||
| --no-dev-deps --exclude libafl_libfuzzer --exclude libafl_qemu --exclude libafl_qemu_sys --exclude libafl_asan_libc --print-command-list; ", | |||
| "DOCS_RS=1 cargo hack check -p libafl_qemu -p libafl_qemu_sys --each-feature --clean-per-run \ | |||
| --exclude-features=prelude,python,sancov_pcguard_edges,arm,aarch64,i386,be,systemmode,whole_archive,slirp,intel_pt,intel_pt_export_raw \ | |||
| --exclude-features=prelude,python,sancov_pcguard_edges,arm,aarch64,i386,be,systemmode,whole_archive,slirp,intel_pt,intel_pt_export_raw,nyx \ | |||
There was a problem hiding this comment.
Can we make this a (rust) list/slice of features that we then join in here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libvharness is a library to help making harnesses for libafl qemu more easily.
there is a new feature to optionally compile
nyxcommand stuff, it should avoid the mess with having both libafl qemu commands and nyx commands altogether we've seen in previous issues.InputSetteris just an abstraction of how the input should be set in qemu. before, it was implemented as part of the command manager, so code reuse was not really possible.SetMapCommandis a new command used to define coverage maps (including cmplog maps) from inside a VM. the main use case is when this gets coupled with something like KCOV. it makes it easier / more efficient to get the correct coverage compared with manual address filtering. the current implementation of KCOV is not enough to get this command working correctly, there is a linux patch to apply I'll try to push soon.