Add input unpacking for tuple inputs in decoder layers #2777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR finishes the work started by @gagika in #2753. Credits to @gagika for uncovering this regression!
This PR fixes a regression introduced in a recent commit where decoder layers began returning a tuple
(hidden_states, kv_cache)even whenscan_layers=False. This caused failures inSequentialBlockDecoderLayers(used in pipeline parallelism) because the subsequent layer would receive a tuple as input instead of a tensor, leading to aValueErrorin normalization layers.Changes
__call__method for all Decoder Layer implementations to handle tuple inputs gracefully:Changes
If the change fixes a bug:
FIXES: b/462751017
Affected Models
This fix covers the following model architectures:
Tests
internal google3 tests.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.