Skip to content

Fix HLO Dump #2795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gobbleturk wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix HLO Dump #2795

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
498d524
Fix hlo dump by adding it to new pyconfig
gobbleturk Dec 8, 2025
fe1057f
Fix hlo dump by adding it to new pyconfig
gobbleturk Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/MaxText/pyconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,25 @@ def _prepare_for_pydantic(raw_keys: dict[str, Any]) -> dict[str, Any]:

return pydantic_kwargs

def validate_and_set_hlo_dump_defaults(raw_keys):
if not raw_keys["dump_hlo"]:
return raw_keys
if os.environ.get("XLA_FLAGS") and raw_keys["dump_hlo_xla_flags"]:
raise ValueError("You must set either XLA_FLAGS or dump_hlo_xla_flags to dump HLO, but not both.")
if not os.environ.get("XLA_FLAGS") and not raw_keys["dump_hlo_xla_flags"]:
raw_keys["dump_hlo_xla_flags"] = f"--xla_dump_to={raw_keys['dump_hlo_local_dir']} --xla_dump_large_constants"
if raw_keys["dump_hlo_local_module_name"]:
raw_keys["dump_hlo_xla_flags"] = (
f"{raw_keys['dump_hlo_xla_flags']} --xla_dump_hlo_module_re={raw_keys['dump_hlo_local_module_name']}"
)
if not raw_keys["dump_hlo_gcs_dir"]:
raw_keys["dump_hlo_gcs_dir"] = os.path.join(raw_keys["base_output_directory"], raw_keys["run_name"], "xla_dump")
print(raw_keys["dump_hlo_gcs_dir"])
else:
raw_keys["dump_hlo_gcs_dir"] = gcs_utils.add_trailing_slash(raw_keys["dump_hlo_gcs_dir"])
if not os.environ.get("XLA_FLAGS"):
os.environ["XLA_FLAGS"] = raw_keys["dump_hlo_xla_flags"]
return raw_keys

class HyperParameters:
"""
Expand Down Expand Up @@ -279,6 +298,8 @@ def initialize(argv: list[str], **kwargs) -> HyperParameters:

compilation_cache.set_cache_dir(os.path.expanduser(pydantic_kwargs["jax_cache_dir"]))

validate_and_set_hlo_dump_defaults(pydantic_kwargs)

pydantic_config = types.MaxTextConfig(**pydantic_kwargs)
config = HyperParameters(pydantic_config)

Expand Down
Loading