Extract lambda to a named function to ensure cache hits. #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_833936348
branch
from
20866ed to
e8adf9b
Compare
The lambda function used in `jax.pmap` within `_test_slice_execution` is moved into a private helper function `_plus_one`. lambda functions have a different hash and were not utilizing the compilation cache. https://docs.jax.dev/en/latest/jit-compilation.html#jit-and-caching PiperOrigin-RevId: 833979645
copybara-service
bot
force-pushed
the
test_833936348
branch
from
e8adf9b to
3b4cacd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract lambda to a named function to ensure cache hits.
The lambda function used in
jax.pmapwithin_test_slice_executionis moved into a private helper function_plus_one. lambda functions have a different hash and were not utilizing the compilation cache.https://docs.jax.dev/en/latest/jit-compilation.html#jit-and-caching
FUTURE_COPYBARA_INTEGRATE_REVIEW=#122 from AI-Hypercomputer:prepare_for_version 53e7715