Configuration Modules for creating user directory, configuration loading...#175
Open
Youbadawy wants to merge 5 commits intoAI4Finance-Foundation:masterfrom
Open
Configuration Modules for creating user directory, configuration loading...#175Youbadawy wants to merge 5 commits intoAI4Finance-Foundation:masterfrom
Youbadawy wants to merge 5 commits intoAI4Finance-Foundation:masterfrom
Conversation
Contributor
|
thanks for your valuable codes. could you pls separate this PR to several PRs? In addition, this branch has conflicts with master. could you pls revise it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear all,
Hope this pull requests finds you all well and in good health,
Sorry for the delay, as requested this is a smaller pull request, with pep8 styling and documentation for the config items,
Goal of PR,
the primary aim for these modules is to facilitate the extraction of data, information, agents, and what not from a unified, standardized location in the repository ( ./user_data).
also I believe we should change the location of the config.json file that was put inside /notebooks to a central config folder in the parent directory. where we will put an example file to retrieve if any user need.
Whats next?
next we have the data fetching for crypto using the ccxt module.
@XiaoYangLiu-FinRL @BruceYanghy @spencerR1992
hope that meets the requirements...