fix: improve error messages and exception handling in sec_utils.py#83
Open
sjhddh wants to merge 1 commit intoAI4Finance-Foundation:masterfrom
Open
fix: improve error messages and exception handling in sec_utils.py#83sjhddh wants to merge 1 commit intoAI4Finance-Foundation:masterfrom
sjhddh wants to merge 1 commit intoAI4Finance-Foundation:masterfrom
Conversation
- Replace hardcoded "2023" with actual search date range in error messages - Replace bare `except:` with `except Exception as e:` for better debugging - Fix typo "downloaded" -> "download" in error messages - Use consistent error message format with hyphen separator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve error handling and messages in
SECUtils.download_10k_filing()andSECUtils.download_10k_pdf().Changes
Replace hardcoded year in error messages
"No 2023 10-K filing found for {ticker}""No 10-K filing found for {ticker} between {start_date} and {end_date}"Improve exception handling
except:withexcept Exception as e:to capture and display the actual errorFix typo
Consistent formatting
{url} - {e}Test plan