Align coords of trendline when passing data array #180
+438
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion issue with test_correlation
This reverts commit 8199ca8.
add poly detrending
Minor fixes polyfit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous implementation the input dataarray when calling
get_trend_timeserieswas always the same shape as the initial data to which the preprocessor was fitted to.But it is likely that one wants to reconstruct the trendline timeseries only the data with the same shape (the same as input lat lon shape).
This is now fixed in sub-optimal solution. Preferably the linear trend line gets stored in the same manner as the polyfit coefficients.