Skip to content

Conversation

@meleneemil
Copy link
Contributor

@meleneemil meleneemil commented Dec 17, 2025

Follow-up from enhancement I suggested:
#900

Example output with this version

#lxplus952 tools master >> ./podio-merge-files --output-file test.root /eos/home-s/sfranche/FCC/samples/bib/ipc/jaeyserm_Z_4IP_29may24_FCCee_Z256_2
T_grids8/ALLEGRO_29may24_FCCee_Z256_2T_grids8/ALLEGRO_o1_v03_99*
Checked input files for duplicates in 0.00 seconds
Initialized reader and writer in 2.97 seconds
Merging: 

 Merging category '      runs': ................................................... 50...............
 Merging category '      meta': ................................................... 50...............
 Merging category '    events': ................................................... 50...............
Merged data categories in 25.74 seconds
Retrieved metadata frames in 1.32 seconds
Wrote metadata frames in 0.14 seconds

BEGINRELEASENOTES

  • podio-merge-files: add progress bar and time measurement per step; add short option for output files argument
    ENDRELEASENOTES

@tmadlener
Copy link
Collaborator

Nice addition. I would go for tqdm in this case, as that handles all of the progress bar stuff and timing and we would not have to do that ourselves.

It has the downside of adding another run-time dependency, but I think that is OK.

@meleneemil
Copy link
Contributor Author

tqdm added. Looking ok, assuming no error printouts

#lxplus969 tools master >> ./podio-merge-files --output-file test.root /eos/home-s/sfranche/FCC/samples/bib/ipc/jaeyserm_Z_4IP_29may24_FCCee_Z256_2T
_grids8/ALLEGRO_29may24_FCCee_Z256_2T_grids8/ALLEGRO_o1_v03_99*
Checked input files for duplicates in 0.00 seconds
Initialized reader and writer in 2.86 seconds
Merging: 
Merging category 'runs'
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████| 66/66 [00:03<00:00, 20.71it/s]
Merging category 'meta'
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████| 66/66 [00:00<00:00, 87.76it/s]
Merging category 'events'
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████| 66/66 [00:17<00:00,  3.70it/s]

Merged data categories in 25.64 seconds
Retrieved metadata frames in 1.30 seconds
Wrote metadata frames in 0.14 seconds

@m-fila
Copy link
Contributor

m-fila commented Dec 17, 2025

Nice, could you also add tqdm to requirements.txt and mention in README under prerequisites for tools (next to graphivz and tabulate)

Copy link
Collaborator

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks a lot. I have a few comments below. There are probably still some formatting issues, which are easily fixed by simply running pre-commit run -a black (inside a Key4hep environment).

@tmadlener tmadlener linked an issue Dec 17, 2025 that may be closed by this pull request
@tmadlener tmadlener enabled auto-merge (squash) December 17, 2025 19:05
@tmadlener tmadlener changed the title podio-merge-files: add progress bar and time measurement for reference podio-merge-files: add progress bar Dec 17, 2025
@tmadlener tmadlener disabled auto-merge December 17, 2025 19:05
@tmadlener tmadlener enabled auto-merge (squash) December 17, 2025 19:05
@tmadlener tmadlener disabled auto-merge December 18, 2025 07:30
@tmadlener tmadlener merged commit 8ba73b6 into AIDASoft:master Dec 18, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

progress printout for podio-merge-files

4 participants