-
Notifications
You must be signed in to change notification settings - Fork 62
podio-merge-files: add progress bar #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Nice addition. I would go for It has the downside of adding another run-time dependency, but I think that is OK. |
|
|
|
Nice, could you also add |
tmadlener
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks a lot. I have a few comments below. There are probably still some formatting issues, which are easily fixed by simply running pre-commit run -a black (inside a Key4hep environment).
Co-authored-by: Thomas Madlener <[email protected]>
Co-authored-by: Thomas Madlener <[email protected]>
Co-authored-by: Thomas Madlener <[email protected]>
Co-authored-by: Thomas Madlener <[email protected]>
Follow-up from enhancement I suggested:
#900
Example output with this version
BEGINRELEASENOTES
ENDRELEASENOTES