Skip to content

Conversation

@m-fila
Copy link
Contributor

@m-fila m-fila commented Jan 19, 2026

BEGINRELEASENOTES

  • find Python3 in find_dependency

ENDRELEASENOTES

Making find_dependecy for consistent with find_package. According to the docs find Python finds Python 3 or fallbacks to Python 2. find Python3 is just Python 3

Closes #912

@tmadlener
Copy link
Collaborator

We also need to change to Python3_EXECUTABLE here, I think:

COMMAND ${Python_EXECUTABLE} ${podio_PYTHON_DIR}/podio_class_generator.py ${CLANG_FORMAT_ARG} ${SCHEMA_EVOLUTION_ARG} ${UPSTREAM_EDM_ARG} ${YAML_FILE} ${ARG_OUTPUT_FOLDER} ${datamodel} ${ARG_IO_BACKEND_HANDLERS} ${LANGUAGE_ARG} ${VERSION_ARG} ${OLD_DESCRIPTION_ARG}

Also this one should probably become a Python3_FIND_FRAMEWORK here:

SET(Python_FIND_FRAMEWORK LAST)

@tmadlener
Copy link
Collaborator

EDM4hep is failing because there was an explicit mention of Python_EXECUTABLE as well which FindPython3 no longer populates. key4hep/EDM4hep#476 should make things such that EDM4hep builds with and without these changes.

@tmadlener tmadlener force-pushed the find_dependency_python branch from b120f46 to 02d1e53 Compare January 19, 2026 18:15
@tmadlener tmadlener enabled auto-merge (squash) January 19, 2026 18:15
@tmadlener tmadlener merged commit 2a69481 into AIDASoft:master Jan 19, 2026
26 checks passed
@m-fila m-fila deleted the find_dependency_python branch January 19, 2026 18:49
tmadlener added a commit to tmadlener/podio that referenced this pull request Jan 19, 2026
* find Python3 in find_dependency

* fix remaining variables

Co-authored-by: Thomas Madlener <[email protected]>

---------

Co-authored-by: Thomas Madlener <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use consistent Python:: or Python3:: targets, in find_package, and in find_dependency

2 participants