Make pythonization for collection subscript header only again #928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of `Python3::Python`, which according to the documentation is meant for embedding the python interpreter.
This should avoid linking issues on macOS, while still - keeping things working via cppyy (most likely via JIT) - allowing usage in c++ modules
Contributor
I can rebase it. |
Member
|
I think however that the source implementation is nice because then downstream projects do not have to care about this. With the header one, every project will have to link to Python plus every translation unit will have to include Python headers (worsening compile times since we talked about this today). |
Collaborator
Author
|
Yeah, also a good point. Since making python an explicit seems to fix thins also on macOS, we could keep the current version. I kind of like the fact that the header-only approach has no traces in the binaries while still working with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
Inspired by #925 and #908 (comment)
It looks like this should keep things building / linking for macOS, while still maintaining the possibility to create c++ modules with it.
@paulgessinger any chance you could give this a go and see if this also works for you?
@wdconinc Should I rebase #907 or will you do it?
In case this works for macOS, I would merge this and tag v01-07-01 afterwards and add a dedicated
conflictto thepodiospack package for mac for1.7.