Fix/calvin logo image path #312
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed asset paths from ../../assets/ to ./assets/ to match webpack output structure where static HTML files and assets folder are both in the dist root directory. This fixes broken images including the Calvin logo, Thoughtful logo, and other icons in seniorProject2024.html and index.html.
Updated all asset paths from ../../assets/ to ./assets/ in: - seniorProject2024.html (logo, GitHub icon, slides, Calvin logo, screenshots) - index.html (logo, sparkle icon, about icon, MS Word UI image) This fixes broken images including the Calvin University logo that were not loading due to incorrect relative paths in the webpack build output.
Changed the navigation logo from logo_black.png to calvin-logo.webp to display Calvin University branding in the top left corner of the index page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.