ideas from the summer #313
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…playwright-automation
staging a visual bug to check for CI workflow
…ctor page navigation ## Summary Addressed 11 of 20 PR review comments by fixing survey questions, removing logging throttles, extracting constants, and refactoring hardcoded page navigation logic. ## Changes ### Survey Questions (surveyData.ts) - Add 3 missing TLX dimensions: physical demand, effort, frustration - Fix debrief text for complete_document condition to clarify AI accuracy expectations (chat provides true context, AI suggestions may be inconsistent) ### Logging (TaskPage.tsx) - Remove document update throttling - now logs every change instead of every 500 characters - Ensures complete data collection for analysis ### Constants (studyConfig.ts) - Extract API_TIMEOUT_MS constant (20 seconds) for consistent timeout handling - Create getNextPage() helper function to replace hardcoded array indices ### Page Navigation Refactoring Update all 5 page navigation components to use getNextPage() helper: - ConsentPage, IntroPage, IntroSurvey, StartTaskPage, PostTaskSurvey - Benefits: self-documenting, maintainable, survives page sequence changes ## Deferred to Backlog Created 8 new backlog tasks for: - Consent form placeholders - Error boundary setup - Parameter validation (no defaulting condition codes) - System message configuration strategy evaluation - WritingArea tests - Scenario content extraction to studyConfig - ChatPanel API response format improvement - AI context enhancement with email metadata 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
… type definitions, and improve logging
- Added chatMessage:user and chatMessage:assistant event types to LogEventType - Implemented logging in ChatPanel using studyParamsAtom for username - Logs capture messageId, content, and timestamp in extra_data - Moved utility functions (getMessageText, parseMessageContent) to module level - Logs are sent to backend via existing /api/log endpoint 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
…urrent experiment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.